netdev - Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45B68249.90507@oracle.com>
Date:	Tue, 23 Jan 2007 13:46:49 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
CC:	Jeff Garzik <jeff@...zik.org>,
	Luca Tettamanti <kronos.it@...il.com>,
	Jay Cliburn <jacliburn@...lsouth.net>, shemminger@...l.org,
	csnook@...hat.com, hch@...radead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, atl1-devel@...ts.sourceforge.net
Subject: Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

Stephen Hemminger wrote:
> On Tue, 23 Jan 2007 16:33:29 -0500
> Jeff Garzik <jeff@...zik.org> wrote:
> 
>> Stephen Hemminger wrote:
>>> IMHO the MSI disabling should be removed from drivers and be done
>>> in the PCI core.
>> That is the consensus opinion.
>>
>> Currently drivers implement the MSI tests because the core PCI code 
>> hasn't been up to snuff.  I (and others) have been discouraging that, 
>> but when a user faces a choice between working and non-working network, 
>> the pragmatic solution wins.

Linus's remark (IIRC) was to not enable CONFIG_PCI_MSI then.

>> All efforts to get us to the point where we can remove the MSI tests 
>> from drivers are strongly supported...
>>
>> 	Jeff
> 
> So far, either MSI works for all devices or is broken, so it makes
> sense to have a "msi=off" boot option (if there isn't already)
> 
There is one, but it's spelled "pci=nomsi".

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html