netdev - Re: [PATCH] bcm43xx: Fix scaling error for 'iwlist freq' information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200701240004.01943.mb@bu3sch.de>
Date:	Wed, 24 Jan 2007 00:04:01 +0100
From:	Michael Buesch <mb@...sch.de>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	John Linville <linville@...driver.com>, netdev@...r.kernel.org,
	Bcm43xx-dev@...ts.berlios.de
Subject: Re: [PATCH] bcm43xx: Fix scaling error for 'iwlist freq' information

On Tuesday 23 January 2007 23:43, Larry Finger wrote:
> The bcm43xx driver returns the available frequencies to 'iwlist freq' with the wrong scaling.
> 
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
> 
> John,
> 
> This is to be applied to wireless-2.6. It could also be sent upstream to 2.6.20,
> but it is not very important.

ACKed. The previous rates-fix patch is also ACKed.

> Larry
> ---
> 
> Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
> +++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
> @@ -286,7 +286,7 @@ static int bcm43xx_wx_get_rangeparams(st
>  		if (j == IW_MAX_FREQUENCIES)
>  			break;
>  		range->freq[j].i = j + 1;
> -		range->freq[j].m = geo->a[i].freq;//FIXME?
> +		range->freq[j].m = geo->a[i].freq * 100000;
>  		range->freq[j].e = 1;
>  		j++;
>  	}
> @@ -294,7 +294,7 @@ static int bcm43xx_wx_get_rangeparams(st
>  		if (j == IW_MAX_FREQUENCIES)
>  			break;
>  		range->freq[j].i = j + 1;
> -		range->freq[j].m = geo->bg[i].freq;//FIXME?
> +		range->freq[j].m = geo->bg[i].freq * 100000;
>  		range->freq[j].e = 1;
>  		j++;
>  	}
> 
> ---
> 
> 
> 

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html