netdev - Re: [PATCH] decnet: handle a failure in neigh_parms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070124.144952.02299886.davem@davemloft.net>
Date:	Wed, 24 Jan 2007 14:49:52 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	netdev@...r.kernel.org, steve@...gwyn.com
Subject: Re: [PATCH] decnet: handle a failure in neigh_parms_alloc

From: David Miller <davem@...emloft.net>
Date: Wed, 24 Jan 2007 14:45:11 -0800 (PST)

> From: ebiederm@...ssion.com (Eric W. Biederman)
> Date: Wed, 24 Jan 2007 13:09:40 -0700
> 
> > 
> > While enhancing the neighbour code to handle multiple network
> > namespaces I noticed that decnet is assuming neigh_parms_alloc
> > will allways succeed, which is clearly wrong.  So handle the
> > failure.
> > 
> > Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> 
> I don't think this one is correct.
> 
> During failure cleanup you also have to invoke the neighbour parms
> ->down() operation if present, else you leave multicast entries on the
> ethernet device for example.

BTW, it occurs to me that a good way to handle this might be to
try and do the neigh_parms_alloc() before running the ->up()
method.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html