lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jan 2007 13:31:33 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: Stephen Hemminger <shemminger@...ux-foundation.org> Cc: <netdev@...r.kernel.org> Subject: Re: [PATCH RFC 2/31] net: Implement a place holder network namespace Stephen Hemminger <shemminger@...ux-foundation.org> writes: >> + >> +#define __per_net_start ((char *)0) >> +#define __per_net_end ((char *)0) > > Don't use these use NULL NULL has the wrong data type. These are compiled out character array normally generated by the linker script. I'm not even certain I need the above but allows for compile time and not link time optimization so it is probably better that way. The fact that these happen to be equal to NULL is their least interesting property. The fact that you can subtract the and get 0 is much more interesting. >> + >> +static inline int copy_net(int flags, struct task_struct *tsk) { return 0; } >> + >> +/* Don't let the list of network namespaces change */ >> +static inline void net_lock(void) {} >> +static inline void net_unlock(void) {} > > Don't make all one line, or use #define instead. Why? Anyway I appreciate the picking of the nits, and it should lead to better code. I guess this implies you are in favor of the general idea of where this is going? Eric - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists