lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jan 2007 13:34:25 -0800 (PST) From: David Miller <davem@...emloft.net> To: baruch@...en.org Cc: netdev@...r.kernel.org, shemminger@...l.org Subject: Re: [PATCH] Fix sorting of SACK blocks From: Baruch Even <baruch@...en.org> Date: Thu, 25 Jan 2007 20:29:03 +0200 > The sorting of SACK blocks actually munges them rather than sort, causing the > TCP stack to ignore some SACK information and breaking the assumption of > ordered SACK blocks after sorting. > > The sort takes the data from a second buffer which isn't moved causing > subsequent data moves to occur from the wrong location. The fix is to > use a temporary buffer as a normal sort does. > > Signed-Off-By: Baruch Even <baruch@...en.org> Thanks for finding this bug Baruch. It probably explains some weird TCP traces I've seen over the years :-) I'll review this and apply it later today, thanks again. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists