netdev - Re: [PATCH] TCP: Replace __kfree_skb() with kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Jan 2007 09:28:38 +0100
From:	Jarek Poplawski <jarkao2@...pl>
To:	Masayuki Nakagawa <nakagawa.msy@...s.nec.co.jp>
Cc:	davem@...emloft.net, yoshfuji@...ux-ipv6.org,
	herbert@...dor.apana.org.au, mhuth@...sta.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()

On 26-01-2007 04:37, Masayuki Nakagawa wrote:
> This patch simply replaces __kfree_skb() in exit path with kfree_skb().
> In tcp_rcv_state_process(), generally skbs should be destroyed only when
> the ref count is zero.
> That is the way things are supposed to be done in the kernel.
> 
> This change might reveals a memory leak of skb.
> If it happens, it would be because someone doesn't deal with the skb properly.

So maybe for some time there should be added skb->users
test with a warning to reveal this?

Regards,
Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html