netdev - Re: [PATCH] Fix sorting of SACK blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070126.004219.11627875.davem@davemloft.net>
Date:	Fri, 26 Jan 2007 00:42:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	baruch@...en.org
Cc:	netdev@...r.kernel.org, shemminger@...l.org
Subject: Re: [PATCH] Fix sorting of SACK blocks

From: Baruch Even <baruch@...en.org>
Date: Fri, 26 Jan 2007 08:40:09 +0200

> You actually need recv_sack_cache to detect if you can use the fast
> path. Another alternative is to somehow hash the values of the sack
> blocks but then you rely on probabilty that you will properly detect the
> ability to use the fast path. Hashing will save some space but you can't
> get rid of it completely unless you go back to the old and slow method
> of SACK processing.
> 
> There were thoughts thrown a while back about using a different data
> structure, I think you said you started working on something like that.
> If that comes to fruition the cache might go.

I don't know if those ideas will go anywhere, it's difficult
to make it work properly and it has to be done right since we'll
likely have to change drivers to handle an aggregated send queue
cleanly and we only want to do that once.

> FWIW, my other mail about possible bugs actually says that you might
> need to add another value to check, the number of sack blocks in the
> cache.

Yes I saw that, I was about to go over that and maybe come up with
some patches.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html