netdev - [PATCH] d80211: configure hardware when the interface is brought up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 25 Jan 2007 19:37:12 -0500
From:	Pavel Roskin <proski@....org>
To:	netdev@...r.kernel.org
Subject: [PATCH] d80211: configure hardware when the interface is brought up

ieee80211_hw_config() is called from scanning functions and ioctl
handlers, but not when the interface is brought up.  This is
unreasonable.  Since the config function is provided by hardware drivers
to d80211, the later should be responsible for calling it in all
situations when the hardware needs to be reconfigured.

Without this patch, bcm43xx_d80211 needs the channel to be set again
after the interface goes down and up.  Similar problems are reported for
rt2x00 drivers.

Failure in ieee80211_hw_config() leads to the interface staying down.

Signed-off-by: Pavel Roskin <proski@....org>
---

 net/d80211/ieee80211.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/d80211/ieee80211.c b/net/d80211/ieee80211.c
index 2f1dce5..7219416 100644
--- a/net/d80211/ieee80211.c
+++ b/net/d80211/ieee80211.c
@@ -2239,6 +2239,8 @@ static int ieee80211_open(struct net_device *dev)
 		res = 0;
 		if (local->ops->open)
 			res = local->ops->open(local_to_hw(local));
+		if (res == 0)
+			res = ieee80211_hw_config(local);
 		if (res == 0) {
 			res = dev_open(local->mdev);
 			if (res) {

-- 
Regards,
Pavel Roskin

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html