netdev - Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45B97755.1030509@ncos.nec.co.jp>
Date:	Thu, 25 Jan 2007 19:36:53 -0800
From:	Masayuki Nakagawa <nakagawa.msy@...s.nec.co.jp>
To:	davem@...emloft.net, yoshfuji@...ux-ipv6.org,
	herbert@...dor.apana.org.au
Cc:	nakagawa.msy@...s.nec.co.jp, mhuth@...sta.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.20-rc5] IPV6: skb is unexpectedly freed.

David, Yoshifuji-san, Herbert,

I appreciate your feedback.

I made an another patch that simply replaced __kfree_skb() in exit path with
kfree_skb(). I tested it overnight with a chat benchmark tool and
my test program, which can reproduce the original problem.

As a result, I didn't see any problem.
(For example, neither oops nor memory leak happened.)

I will post the patch a few moments later. Please take a look at it.

Thanks,
Masa

David Miller wrote:
> From: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> Date: Wed, 24 Jan 2007 13:37:25 +0900 (JST)
>
>   
>> In article <E1H9ZnX-0001z5-00@...dolin.me.apana.org.au> (at Wed, 24 Jan 2007 15:31:47 +1100), Herbert Xu <herbert@...dor.apana.org.au> says:
>>
>>     
>>> Masayuki Nakagawa <nakagawa.msy@...s.nec.co.jp> wrote:
>>>       
>>>> I suggest to use kfree_skb() instead of __kfree_skb().
>>>>         
>>> I agree.  In fact please do it for all paths in that function, i.e.,
>>> just change __kfree_skb to kfree_skb rather than adding a special case
>>> for this path.
>>>       
>> I do think so, too.
>>     
>
> So do I, but initially I want to push his basic patch in
> so that I can push the same exact thing into -stable to
> fix this bug.
>
> So if you make the subsequent change, please make it relative
> to the original patch.
>
> Thank you.
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>   
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html