lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 28 Jan 2007 20:04:48 +0100 From: Francois Romieu <romieu@...zoreil.com> To: netdev@...r.kernel.org Subject: Re: r8169: Crash after reloading driver if network hangs Bernhard Walle <bwalle@...e.de> : [...] > Simple fix is attached. Although that seems to fix the symptom and not > the cause, please apply it if you don't have a better solution. What about the patch below ? diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 577babd..4e22af7 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1373,7 +1373,7 @@ static inline void rtl8169_request_timer(struct net_device *dev) timer->expires = jiffies + RTL8169_PHY_TIMEOUT; timer->data = (unsigned long)(dev); timer->function = rtl8169_phy_timer; - add_timer(timer); + mod_timer(timer); } #ifdef CONFIG_NET_POLL_CONTROLLER @@ -1448,7 +1448,7 @@ static void rtl8169_init_phy(struct net_device *dev, struct rtl8169_private *tp) rtl8169_phy_reset(dev, tp); - rtl8169_set_speed(dev, autoneg, speed, duplex); + tp->set_speed(dev, autoneg, speed, duplex); if ((RTL_R8(PHYstatus) & TBI_Enable) && netif_msg_link(tp)) printk(KERN_INFO PFX "%s: TBI auto-negotiating\n", dev->name); - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists