netdev - RE: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <78C9135A3D2ECE4B8162EBDCE82CAD770125FFD8@nekter>
Date:	Mon, 29 Jan 2007 01:05:31 -0500
From:	"Sivakumar Subramani" <Sivakumar.Subramani@...erion.com>
To:	<netdev@...r.kernel.org>, "Jeff Garzik" <jeff@...zik.org>
Cc:	"Leonid Grossman" <Leonid.Grossman@...erion.com>,
	"Ananda Raju" <Ananda.Raju@...erion.com>,
	"Sreenivasa Honnur" <Sreenivasa.Honnur@...erion.com>,
	"Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>,
	"Rastapur Santosh" <santosh.rastapur@...erion.com>,
	"Sriram Rapuru" <Sriram.Rapuru@...erion.com>
Subject: RE: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

Hi Jeff,

As per your comment I have synced up the patch with the latest
netdev-2.6.git#upstream branch. Also I have corrected the white space
issue. I have resubmitted the patches again.

Thanks,
~Siva
-----Original Message-----
From: Jeff Garzik [mailto:jeff@...zik.org]
Sent: Wednesday, January 24, 2007 2:56 AM
To: Ananda Raju
Cc: nBetdev@...r.kernel.org; Leonid Grossman; Alicia Pena; Ramkrishna
Vepa; Sreenivasa Honnur; Sriram Rapuru
Subject: Re: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module
loadable parameter.

Ananda Raju wrote:
> This patch adds two load parameters napi and ufo. Previously NAPI was 
> compilation option with these changes wan enable disable NAPI using 
> load parameter. Also we are introducing ufo load parameter to 
> enable/disable ufo feature
> 
> Signed-off-by: Sivakumar Subramani <sivakumar.subramani@...erion.com>

ACK patches 1-5, but patch does not apply to netdev-2.6.git#upstream. 
Also, git-am complains about whitespace.

[jgarzik@...tzel netdev-2.6]$ git-am --signoff --utf8 /g/tmp/mbox

Applying 's2io: Making LRO and UFO as module loadable parameter.'

Space in indent is followed by a tab.
.dotest/patch:41:                       (block_no * 
(rxd_count[nic->rxd_mode] + 1)) + off;
Adds trailing whitespace.
.dotest/patch:46:               }
Space in indent is followed by a tab.
.dotest/patch:137:              * Rx handler is called by default, 
without checking for the
Space in indent is followed by a tab.
.dotest/patch:138:              * cause of interrupt.
Space in indent is followed by a tab.
.dotest/patch:139:              * rx_traffic_int reg is an R1 register, 
writing all 1's
error: patch failed: drivers/net/s2io.c:6985
error: drivers/net/s2io.c: patch does not apply Patch failed at 0001.
When you have resolved this problem run "git-am --resolved".
If you would prefer to skip this patch, instead run "git-am --skip".
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html