netdev - Re: igmp: possible NULL dereference after GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF52248A96.35A5CA3C-ON88257273.003E5791-88257273.003F9122@us.ibm.com>
Date:	Tue, 30 Jan 2007 03:34:18 -0800
From:	David Stevens <dlstevens@...ibm.com>
To:	Alexey Dobriyan <adobriyan@...nvz.org>
Cc:	davem@...emloft.net, kuznet@....inr.ac.ru, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org
Subject: Re: igmp: possible NULL dereference after GFP_ATOMIC allocation?

Alexey,
        I think you're correct-- looks like it needs:

        if (!skb)
                return NULL;

just before the skb_put(), since an allocation (and failure)
could occur in either the igmpv3_newpack() call or in add_grhead().
        Also, similar code in net/ipv6/mcast..c.

        Will you be submitting the patch?

                                        +-DLS

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html