netdev - Re: [PATCH] PA Semi PWRficient Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070130153626.GB25309@lixom.net>
Date:	Tue, 30 Jan 2007 09:36:26 -0600
From:	olof@...om.net (Olof Johansson)
To:	Christoph Hellwig <hch@...radead.org>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH] PA Semi PWRficient Ethernet driver

On Tue, Jan 30, 2007 at 10:03:58AM +0000, Christoph Hellwig wrote:
> On Mon, Jan 29, 2007 at 12:08:52AM -0600, Olof Johansson wrote:
> > Driver for the PA Semi PWRficient on-chip Ethernet (1/10G)
> > 
> > Basic enablement, will be complemented with performance enhancements
> > over time. PHY support will be added as well.
> > 
> > This patch still uses the numerical PCI vendor id, it will be replaced
> > when the pci_ids.h change goes in (same as the other currently pending
> > drivers).
> 
> >From a quick glance over the code you don't seem to handle memory allocation
> erros at all, that needs some fixing.

v2 that I posted as a comment to the first one should have taken care
of most cases. I'll go through once more and see if I missed any before
posting a revised version later today.


Thanks,

-Olof
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html