netdev - Re: buggy IFB driver change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070130.141240.97296236.davem@davemloft.net>
Date:	Tue, 30 Jan 2007 14:12:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jgarzik@...ox.com
Cc:	netdev@...r.kernel.org, m.kozlowski@...land.pl, akpm@...l.org,
	torvalds@...ux-foundation.org
Subject: Re: buggy IFB driver change

From: Jeff Garzik <jgarzik@...ox.com>
Date: Tue, 30 Jan 2007 16:52:27 -0500

> David Miller wrote:
> > Jeff, please revert: 0c0b3ae68ec93b1db5c637d294647d1cca0df763
> > 
> > It's wrong.  We had a lengthy analysis of this piece of code
> > several months ago, and it is correct.
> > 
> > Consider, if we run the loop and we get an error
> > the following happens:
> > 
> > 1) attempt of ifb_init_one(i) fails, therefore we should
> >    not try to "ifb_free_one()" on "i" since it failed
> > 2) the loop iteration first increments "i", then it
> >    check for error
> > 
> > Therefore we must decrement "i" twice before the first
> > free during the cleanup.  One to "undo" the for() loop
> > increment, and one to "skip" the ifb_init_one() case which
> > failed.
> > 
> > commit 0c0b3ae68ec93b1db5c637d294647d1cca0df763
> > Author: Mariusz Kozlowski <m.kozlowski@...land.pl>
> 
> Andrew and I both missed that thread, sorry.
> 
> I'm about to crash, can you or Linus handle the correction?

Sure.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html