netdev - Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45C07275.9010501@garzik.org>
Date:	Wed, 31 Jan 2007 05:41:57 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Divy Le Ray <None@...lsio.com>
CC:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	swise@...ngridcomputing.com, David Miller <davem@...emloft.net>
Subject: Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.

Divy Le Ray wrote:
> From: Divy Le Ray <divy@...lsio.com>
> 
> Offload packets may be DMAed long after their SGE Tx descriptors are done
> so they must remain mapped until they are freed rather than until their
> descriptors are freed.  Unmap such packets through an skb destructor.
> 
> Signed-off-by: Divy Le Ray <divy@...lsio.com>

this is questionable and sounds like you are working around a bug.  I 
can't think of another driver that uses skb destructors, and I could 
have sworn that skb destructors were not for drivers to use anyway

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html