netdev - Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070201032040.GA11564@lixom.net>
Date:	Wed, 31 Jan 2007 21:20:40 -0600
From:	olof@...om.net (Olof Johansson)
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org,
	Francois Romieu <romieu@...zoreil.com>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH] [v3] PA Semi PWRficient Ethernet driver

On Wed, Jan 31, 2007 at 10:38:06AM -0800, Stephen Hemminger wrote:
> O
> > +static noinline void pasemi_mac_free_tx_resources(struct net_device *dev)
> 
> Why tell compiler how to do it's job.  marking it noinline?

Leftover from debugging. Gone in the next version.

> Mixing definitions and structure values gets confusing.

I find if the definitions are few, having them near the structure
definition is easier to read. This is way past the limit for that
though. I'll move them.


Thanks,

-Olof
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html