netdev - Re: [PATCH] r8169: fix a race between PCI probe and dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0701311655050.3632@woody.linux-foundation.org>
Date:	Wed, 31 Jan 2007 16:55:55 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Francois Romieu <romieu@...zoreil.com>
cc:	netdev@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	jgarzik@...ox.com, Bernhard Walle <bwalle@...e.de>
Subject: Re: [PATCH] r8169: fix a race between PCI probe and dev_open



On Wed, 31 Jan 2007, Francois Romieu wrote:

> Call chain:
> -> rtl8169_init_one
>    -> register_netdev                  (dev_open starts to race...)
>    -> rtl8169_init_phy
>       -> rtl8169_set_speed
>          -> tp->set_speed
>          -> mod_timer(&tp->timer, ...) (if netif_running() is true)
> 
> As netif_running() is true just before dev->open() is issued and the
> timer is initialized during dev->open, mod_timer() meets an uninitialized
> tp->timer and oopses.

Doesn't this basically mean that *any* use of "rtl8169_set_speed()" is 
buggy?

Anyway, I'm going to wait for somebody smarter than me to ACK this patch. 
Jeff?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html