netdev - Re: [PATCH 3/3] d80211-p54: Add control structure for beacontemplates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702031740.30569.IvDoorn@gmail.com>
Date:	Sat, 3 Feb 2007 17:40:30 +0100
From:	Ivo van Doorn <ivdoorn@...il.com>
To:	Michael Wu <flamingice@...rmilk.net>
Cc:	Jiri Benc <jbenc@...e.cz>,
	"John Linville" <linville@...driver.com>,
	Michael Buesch <mb@...sch.de>, netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] d80211-p54: Add control structure for beacontemplates

On Saturday 03 February 2007 17:33, Michael Wu wrote:
> On Saturday 03 February 2007 11:25, Ivo van Doorn wrote:
> > p54 seems to ignore the beacon that is being passed,
> > even though it is requesting the BEACON_TEMPLATE.
> > That is why I not only added a line to free the control structure
> > but also the beacon itself.
> >
> Yeah, beacons aren't actually handled yet. BEACON_TEMPLATE can just be turned 
> off for now if it's causing problems, though I don't see a reason why a 
> beacon would be generated for managed mode.

It would only be generated for AP mode.
In any case, the new patch:

Signed-off-by Ivo van Doorn <IvDoorn@...il.com>

---

diff --git a/drivers/net/wireless/d80211/p54/prism54common.c b/drivers/net/wireless/d80211/p54/prism54common.c
index fd4ea5d..8335f99 100644
--- a/drivers/net/wireless/d80211/p54/prism54common.c
+++ b/drivers/net/wireless/d80211/p54/prism54common.c
@@ -766,8 +766,7 @@ struct ieee80211_hw *p54_init_common(size_t priv_data_len)
 	priv->modes[0].rates = priv->rates;
 	priv->modes[0].num_channels = ARRAY_SIZE(p54_channels);
 	priv->modes[0].channels = priv->channels;
-	dev->flags = IEEE80211_HW_HOST_GEN_BEACON_TEMPLATE |
-		    IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING | /* not sure */
+	dev->flags = IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING | /* not sure */
 		    IEEE80211_HW_RX_INCLUDES_FCS |
 		    IEEE80211_HW_WEP_INCLUDE_IV |
 		    IEEE80211_HW_DATA_NULLFUNC_ACK; /* TODO: check */
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html