netdev - Re: [PATCH] ipv4: remove a call to skb_queue_len() in inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 4 Feb 2007 21:41:35 +0100
From:	"Thomas Hisch" <t.hisch@...il.com>
To:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: remove a call to skb_queue_len() in inet_diag.c

On 2/4/07, David Miller <davem@...emloft.net> wrote:
> From: Thomas Hisch <t.hisch@...il.com>
> Date: Sun, 4 Feb 2007 15:29:21 +0100
>
> > remove unneeded call to skb_queue_len (skb_dequeue already checks queuelen) and
> > replace a sizeof() by a Netlink Macro
> >
> > Signed-off-by: Thomas Hisch <t.hisch@...il.com>
>
> You don't understand the code you are editing :-)
>
> We want to process the number of packets present when we
> start the function, other threads can add more packets to
> the queue meanwhile and we don't want to keep dequeueing
> in that case or else we can theoretically run forever with
> a fast enough producer.
>
> Also, please post all networking patches to netdev@...r.kernel.org,
> the majority of the networking developers do not read linux-kernel.
>
> Thank you.
>
thanks for the advice. next time i should look more closely at the code ;)

i thought that this was a candidate for a cleanup as no other netlink
protocol used such a while loop condition.

Thomas.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html