netdev - Re: [PATCH 1/3] d80211: Add control structure for beacontemplates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070205212802.36477fd4@griffin.suse.cz>
Date:	Mon, 5 Feb 2007 21:28:02 +0100
From:	Jiri Benc <jbenc@...e.cz>
To:	Ivo van Doorn <ivdoorn@...il.com>
Cc:	"John Linville" <linville@...driver.com>,
	Michael Buesch <mb@...sch.de>,
	Michael Wu <flamingice@...rmilk.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] d80211: Add control structure for beacontemplates

On Sat, 3 Feb 2007 17:25:18 +0100, Ivo van Doorn wrote:
> When rt2500usb and rt73usb will start using beacontemplates,
> they would also need a control structure to be passed along to
> correctly set the tx parameters.

Good catch, thanks.

> This patch will add the allocation an initialization of a
> ieee80211_tx_control especially for the beacontemplate.
> 
> This does require drivers that have the BEACON_TEMPLATE flag
> set to also free the control structure. (bcm43xx and p54 will be
> fixed in the next 2 patches)

I would prefer using local variable for tx_control. Driver will be
responsible for copying it somewhere if it needs to. I believe most
drivers won't need to do that and it will prevent potential memory
leaks as it's easy to forget to free the structure.

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html