netdev - Re: [PATCH] apply cwnd rules to FIN packets with data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070205.145615.92339659.davem@davemloft.net>
Date:	Mon, 05 Feb 2007 14:56:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jheffner@....edu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] apply cwnd rules to FIN packets with data

From: John Heffner <jheffner@....edu>
Date: Mon, 05 Feb 2007 16:58:18 -0500

> This is especially important with TSO enabled.  Currently, it will send 
> a burst of up to 64k at the end of a connection, even when cwnd is much 
> smaller than 64k.  This patch still lets out empty FIN packets, but does 
> not apply the special case to FINs carrying data.

Good catch John.

But I think the correct test on skb->len would be to just make
sure that it is <= REAL_MSS.

What do you think about that?  This would match the original intention
of the logic in the pre-TSO days.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html