netdev - Re: [patch 01/11] user of the jiffies rounding code: Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070205.180111.36663426.davem@davemloft.net>
Date:	Mon, 05 Feb 2007 18:01:11 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org, arjan@...ux.intel.com, jgarzik@...ox.com
Subject: Re: [patch 01/11] user of the jiffies rounding code: Networking

From: akpm@...ux-foundation.org
Date: Mon, 05 Feb 2007 16:30:52 -0800

> From: Arjan van de Ven <arjan@...ux.intel.com>
> 
> This patch introduces users of the round_jiffies() function in the networking
> code.
> 
> These timers all were of the "about once a second" or "about once every X
> seconds" variety and several showed up in the "what wakes the cpu up" profiles
> that the tickless patches provide.  Some timers are highly dynamic based on
> network load; but even on low activity systems they still show up so the
> rounding is done only in cases of low activity, allowing higher frequency
> timers in the high activity case.
> 
> The various hardware watchdogs are an obvious case; they run every 2 seconds
> but aren't otherwise specific of exactly when they need to run.
> 
> Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

I pulled in everything except the e1000 driver change, Jeff please
suck that in, thanks.

Arjan, btw:

> +	if (dst_gc_timer_expires > 4*HZ)
> +		mod_timer(&dst_gc_timer,
> +			round_jiffies(jiffies + dst_gc_timer_expires));
> +	else
> +		mod_timer(&dst_gc_timer, jiffies + dst_gc_timer_expires);
   ^^^^^^^^^^^^^

That line begins "TAB SPACE TAB", and lo' and behold GIT
catch this when I applied it :-)  I fixed it up by hand
and reapplied, so don't worry about this instance.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html