netdev - Re: [patch 11/11] netfilter warning fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070206.114325.98862918.davem@davemloft.net>
Date:	Tue, 06 Feb 2007 11:43:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mingo@...e.hu
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org, kaber@...sh.net,
	dipankar@...ibm.com, paulmck@...ibm.com
Subject: Re: [patch 11/11] netfilter warning fix

From: Ingo Molnar <mingo@...e.hu>
Date: Tue, 6 Feb 2007 13:34:01 +0100

> 
> * Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > On Mon, 05 Feb 2007 18:44:08 -0800 (PST) David Miller 
> > <davem@...emloft.net> wrote:
> > 
> > > I bet this rcu_read_lock()-implies-preempt_disable() assumption has 
> > > spread into other areas of the tree as well.
> > 
> > Me too.  Although one expects that other holes will cause might_sleep 
> > or lockdep warnings pretty easily.
> > 
> > Still, life is hard enough as it is.  I think I'll shelve rcu-preempt 
> > pending resolution of this.
> 
> that was pretty much the only place in the whole kernel that got hit by 
> some rcu-preempt side-effect - and even this appears to show that it's a 
> real bug that was in hiding.

No, rather, it's the only location that triggered an automated
debugging check.  The very first set of code paths we checked, in
response to the bug trigger, showed beyond a shadow of a doubt that
this assumption is pervasive and in many locations that none of the
automated debugging checks live.

The tree should be fully audited before such a huge semantic change
gets added into the tree.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html