netdev - Re: [PATCH 5/7] sky2: Yukon Extreme support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070206215256.GA28967@electric-eye.fr.zoreil.com>
Date:	Tue, 6 Feb 2007 22:52:56 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 5/7] sky2: Yukon Extreme support

Stephen Hemminger <shemminger@...ux-foundation.org> :
[...]
> @@ -289,8 +289,10 @@
>  	struct sky2_port *sky2 = netdev_priv(hw->dev[port]);
>  	u16 ctrl, ct1000, adv, pg, ledctrl, ledover, reg;
>  
> -	if (sky2->autoneg == AUTONEG_ENABLE &&
> -	    !(hw->chip_id == CHIP_ID_YUKON_XL || hw->chip_id == CHIP_ID_YUKON_EC_U)) {
> +	if (sky2->autoneg == AUTONEG_ENABLE
> +	    && !(hw->chip_id == CHIP_ID_YUKON_XL
> +		 || hw->chip_id == CHIP_ID_YUKON_EC_U
> +		 || hw->chip_id == CHIP_ID_YUKON_EX)) {
[...]
> +			if (sky2->autoneg == AUTONEG_ENABLE
> +			    && (hw->chip_id == CHIP_ID_YUKON_XL
> +				|| hw->chip_id == CHIP_ID_YUKON_EC_U
> +				|| hw->chip_id == CHIP_ID_YUKON_EX)) {
[...]
> +	if (hw->chip_id == CHIP_ID_YUKON_XL
> +	    || hw->chip_id == CHIP_ID_YUKON_EC_U
> +	    || hw->chip_id == CHIP_ID_YUKON_EX) {
[...]
> +	if (hw->chip_id == CHIP_ID_YUKON_XL
> +	    || hw->chip_id == CHIP_ID_YUKON_EC_U
> +	    || hw->chip_id == CHIP_ID_YUKON_EX)

Any objection against the use of :

static bool is_yukon_extreme(struct sky2_hw *hw)
{
	return hw->chip_id == CHIP_ID_YUKON_XL ||
		hw->chip_id == CHIP_ID_YUKON_EC_U ||
		hw->chip_id == CHIP_ID_YUKON_EX;
}

?

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html