netdev - [PATCH] bcm43xx: Fix incorrect definition of PHY revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <45c94821.qjljSnUzfws7mU7T%Larry.Finger@lwfinger.net>
Date:	Tue, 06 Feb 2007 21:31:45 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	John Linville <linville@...driver.com>
Cc:	Michael Buesch <mb@...sch.de>, netdev@...r.kernel.org,
	Bcm43xx-dev@...ts.berlios.de, linux-wireless@...r.kernel.org
Subject: [PATCH] bcm43xx: Fix incorrect definition of PHY revision

There is a typographical error in the spefications that interchange the PHY version
and revision. Fixing this error makes all BCM43xx varieties work at full CCCK rates.

Signed-off-by: Larry Finger<Larry.Finger@...inger.net>
---

John,

This patch should be put into wireless-2.6 and into 'upstream' as soon as possible.
I will be sending it to stable for inclusion in 2.6.20.1, and whatever other kernels
are still being maintained by -stable.

Larry
---
 
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -3704,9 +3704,9 @@ static int bcm43xx_read_phyinfo(struct b
 
 	value = bcm43xx_read16(bcm, BCM43xx_MMIO_PHY_VER);
 
-	phy_version = (value & 0xF000) >> 12;
+	phy_rev = (value & 0xF000) >> 12;
 	phy_type = (value & 0x0F00) >> 8;
-	phy_rev = (value & 0x000F);
+	phy_version = (value & 0x000F);
 
 	dprintk(KERN_INFO PFX "Detected PHY: Version: %x, Type %x, Revision %x\n",
 		phy_version, phy_type, phy_rev);

===

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html