[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <6D988EC5-4F41-45FA-9FBF-2AC5731D9B27@kernel.crashing.org>
Date: Wed, 7 Feb 2007 10:36:58 -0600
From: Kumar Gala <galak@...nel.crashing.org>
To: Li Yang-r58472 <LeoLi@...escale.com>
Cc: <jeff@...zik.org>, <netdev@...r.kernel.org>,
<linuxppc-dev@...abs.org>
Subject: Re: [PATCH 1/4] ucc_geth: Change private immrbar_virt_to_phys to generic iopa
On Feb 7, 2007, at 3:34 AM, Li Yang-r58472 wrote:
>> On Feb 6, 2007, at 5:31 AM, Li Yang wrote:
>>
>>> Get rid of private immrbar_virt_to_phys() routine and
>>> use generic iopa().
>>
>> Nack. iopa() isn't that generic, shouldn't we really be using the dma
>> mapping API here?
>
> Do you mean the dma_map_single()? dma_map_single can map memory space
> correctly, but I don't think it can handle ioremap-ed space.
What are you mapping? It looks like buffer descriptor rings. Are
they being kept in QE sram? If so that I think you can treat it as
memory. (I believe the SRAM behaves like memory, is cache-coherent,
etc).
- k
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists