netdev - Re: [PATCH] cxgb3 - convert to user struct device instead of class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070208211911.GA20988@suse.de>
Date:	Thu, 8 Feb 2007 13:19:11 -0800
From:	Greg KH <gregkh@...e.de>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Jeff Garzik <jeff@...zik.org>, Divy Le Ray <divy@...lsio.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

On Thu, Feb 08, 2007 at 12:41:28PM -0800, Roland Dreier wrote:
> Commit 43cb76d9 ("Network: convert network devices to use struct
> device instead of class_device") breaks the just-merged cxgb3 driver,
> since the code that was merged predates the change and was not in the
> tree when Greg made the change.
> 
> This patch fixes cxgb3 to build with the change.  It also removes the
> private to_net_dev() macro and changes the use of bare netdev->priv in
> favor of netdev_priv(netdev) in the sysfs attribute functions.
> 
> I tested this on my system which has cxgb3 hardware, and it looks like
> all the sysfs files are created correctly and contain sane-looking
> values, although I don't actually know how to test that every
> attribute is working as it should.

If it compiles with no warnings, it should be safe.

> Signed-off-by: Roland Dreier <rolandd@...co.com>

Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

But I think Jeff already has a patch in the queue that makes this very
change :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html