netdev - Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 Feb 2007 14:01:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	dhowells@...hat.com, netdev@...r.kernel.org, herbert.xu@...hat.com,
	hch@...radead.org, arjan@...radead.org
Subject: Re: [PATCH 0/5] [RFC] AF_RXRPC socket family implementation

From: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Date: Fri, 09 Feb 2007 01:55:39 +0900 (JST)

> In article <20070208163211.23973.5877.stgit@...thog.cambridge.redhat.com> (at Thu, 08 Feb 2007 16:32:11 +0000), David Howells <dhowells@...hat.com> says:
> 
> >  (2) A local address can optionally be bound:
> > 
> > 	struct sockaddr_rxrpc srx = {
> > 		.srx_family	= AF_RXRPC,
> > 		.srx_service	= 0,  /* we're a client */
> > 		.transport_type	= SOCK_DGRAM,	/* type of transport socket */
> > 		.transport.sin_family	= AF_INET,
> > 		.transport.sin_port	= htons(7000), /* AFS callback */
> > 		.transport.sin_address	= 0,  /* all local interfaces */
> > 	};
> 
> This sockaddr_rxrpc{} should NOT include sockaddr_in{} directly.
> Please use sockaddr_storage{} (or sockaddr{}, maybe), and make it
> sure to align on 64-bit word.

This is correct.

David, we should make the suggested changes in order to support IPv6
(and theoretically other address families as the transport) cleanly.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html