netdev - Re: [PATCH] NET : UDP can use sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070209.154511.92582666.davem@davemloft.net>
Date:	Fri, 09 Feb 2007 15:45:11 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET : UDP can use sk_hash to speedup lookups

From: Eric Dumazet <dada1@...mosbay.com>
Date: Fri, 9 Feb 2007 18:44:16 +0100

> In a prior patch, I introduced a sk_hash field (__sk_common.skc_hash)  to let 
> tcp lookups use one cache line per unmatched entry instead of two.
> 
> We can also use sk_hash to speedup UDP part as well. We store in sk_hash the 
> hnum value, and use sk->sk_hash (same cache line than 'next' pointer), 
> instead of inet->num (different cache line)
> 
> Note : We still have a false sharing problem for SMP machines, because 
> sock_hold(sock) dirties the cache line containing the 'next' pointer. Not 
> counting the udp_hash_lock rwlock. (did someone mentioned RCU ? :) )
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied, thanks Eric.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html