netdev - Re: A potential bug in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070208.160845.115912909.davem@davemloft.net>
Date:	Thu, 08 Feb 2007 16:08:45 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	davidwei79@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: A potential bug in tcp_vegas.c

From: "Xiaoliang (David) Wei" <davidwei79@...il.com>
Date: Thu, 1 Feb 2007 13:03:49 -0800

> I am testing tcp_vegas.c in Linux with the NS-2 TCP-Linux.
> It seems that the ssthresh is not correctly reset to 2 in the
> "tcp_vegas_cong_avoid" function.
> The problem might lead to very unfair behavior among Vegas flows, when
> some flows exit slow start due to loss, not delay.
> 
> Please see the detailed effect at:
> http://www.cs.caltech.edu/%7Eweixl/technical/ns2linux/known_linux/#vegas
> (the section of "Setting of Slow-Start-Threshold")
> 
> A patch I wrote (for Linux 2.6.19-2) is attached.
> Basically, the branch that sets ssthresh to be 2 should be outside the
> condition of (cwnd<=ssthresh).

Please provide a proper "Signed-off-by: " line, see
linux/Documentation/SubmittingPatches for details.

Your patch we not correctly rooted in the tree, the
diff file lines should use paths like:

--- a/net/ipv4/tcp_vegas.c.old     2007-02-01 00:33:55.000000000 -0800
+++ b/net/ipv4/tcp_vegas.c 2007-02-01 00:39:49.000000000 -0800

Again, see linux/Documentation/SubmittingPatches.

Also, GMAIL has corrupted your patch, turning all tab
characters into spaces, so that patch will not apply
properly.

If in doubt, try emailing the patch to yourself and
successfully applying it.

Please fix this up and resubmit, thank you.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html