netdev - Re: [PATCH] bcm43xx: Fix loss of association after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702091753.12419.mb@bu3sch.de>
Date:	Fri, 9 Feb 2007 17:53:12 +0100
From:	Michael Buesch <mb@...sch.de>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	John Linville <linville@...driver.com>, netdev@...r.kernel.org,
	Bcm43xx-dev@...ts.berlios.de, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] bcm43xx: Fix loss of association after resume

On Friday 09 February 2007 17:18, Larry Finger wrote:
> After a suspend/resume cycle, bcm43xx-softmac has lost its association with
> the AP and requires manual intervention. This situation is fixed by making
> one of softmac's internal routines public and calling it.
> 
> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>

Ack, this is good as workaround.

> 
> Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> +++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> @@ -4278,6 +4278,7 @@ static int bcm43xx_resume(struct pci_dev
>  {
>  	struct net_device *net_dev = pci_get_drvdata(pdev);
>  	struct bcm43xx_private *bcm = bcm43xx_priv(net_dev);
> +	struct ieee80211softmac_device *mac = ieee80211_priv(net_dev);
>  	int err = 0;
>  
>  	dprintk(KERN_INFO PFX "Resuming...\n");
> @@ -4299,6 +4300,9 @@ static int bcm43xx_resume(struct pci_dev
>  	}
>  	netif_device_attach(net_dev);
>  
> +	if (mac->associnfo.associated)
> +		ieee80211softmac_try_reassoc(mac);
> +
>  	dprintk(KERN_INFO PFX "Device resumed.\n");
>  
>  	return 0;
> Index: linux-2.6/include/net/ieee80211softmac.h
> ===================================================================
> --- linux-2.6.orig/include/net/ieee80211softmac.h
> +++ linux-2.6/include/net/ieee80211softmac.h
> @@ -254,6 +254,7 @@ struct ieee80211softmac_device {
>  };
>  
>  extern void ieee80211softmac_scan_finished(struct ieee80211softmac_device *sm);
> +extern void ieee80211softmac_try_reassoc(struct ieee80211softmac_device *mac);
>  
>  static inline void * ieee80211softmac_priv(struct net_device *dev)
>  {
> Index: linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> ===================================================================
> --- linux-2.6.orig/net/ieee80211/softmac/ieee80211softmac_assoc.c
> +++ linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
> @@ -441,6 +441,7 @@ ieee80211softmac_try_reassoc(struct ieee
>  	schedule_delayed_work(&mac->associnfo.work, 0);
>  	spin_unlock_irqrestore(&mac->lock, flags);
>  }
> +EXPORT_SYMBOL_GPL(ieee80211softmac_try_reassoc);
>  
>  int
>  ieee80211softmac_handle_disassoc(struct net_device * dev,
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html