netdev - Re: [PATCH] zd1211rw: Readd zd_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1171133498.20342.59.camel@localhost>
Date:	Sat, 10 Feb 2007 10:51:37 -0800
From:	Joe Perches <joe@...ches.com>
To:	Michael Buesch <mb@...sch.de>
Cc:	Daniel Drake <dsd@...too.org>, linville@...driver.com,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	kune@...ne-taler.de, rpjday@...dspring.com
Subject: Re: [PATCH] zd1211rw: Readd zd_addr_t cast

On Sat, 2007-02-10 at 07:02 +0100, Michael Buesch wrote:
> On Saturday 10 February 2007 02:27, Daniel Drake wrote:
> > Robert P.J. Day's recent commit ("getting rid of all casts of k[cmz]alloc()
> > calls") introduced a sparse warning for zd1211rw, related to our type-checking
> > of addresses.
> > > 	zd_chip.c:116:15: warning: implicit cast to nocast type
> > This patch readds the type cast, it is correct.
> > Signed-off-by: Daniel Drake <dsd@...too.org>
> > Index: linux/drivers/net/wireless/zd1211rw/zd_chip.c
> > ===================================================================
> > --- linux.orig/drivers/net/wireless/zd1211rw/zd_chip.c
> > +++ linux/drivers/net/wireless/zd1211rw/zd_chip.c
> > @@ -113,7 +113,7 @@ int zd_ioread32v_locked(struct zd_chip *
> >  
> >  	/* Allocate a single memory block for values and addresses. */
> >  	count16 = 2*count;
> > -	a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> > +	a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)),
> >  		                   GFP_NOFS);

I think it better to remove this __nocast instead.
This is the only use of __nocast outside of kmem in the kernel tree.

Why not just remove __nocast and use u16 instead of zd_addr_t?

If not the removal of the __nocast, would it be better to have a
void pointer there?

	tmp = kcalloc(count16, sizeof(zd_addr_t) + sizeof(u16), GFP_KERNEL);
	[]
	a16 = (zd_addr_t *)tmp;
	v16 = a16 + count16;
	[]
	kfree(tmp);

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html