netdev - Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1HGNZ6-0002j3-00@gondolin.me.apana.org.au>
Date:	Mon, 12 Feb 2007 09:53:00 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	romieu@...zoreil.com (Francois Romieu)
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	shemminger@...ux-foundation.org, lpiccilli@...re.com.br,
	bugme-daemon@...zilla.kernel.org
Subject: Re: [Bugme-new] [Bug 7974] New: BUG: scheduling while atomic: swapper/0x10000100/0

Francois Romieu <romieu@...zoreil.com> wrote:
> 
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index e76539a..a4bcfe2 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -673,7 +673,7 @@ void rtmsg_ifinfo(int type, struct net_device *dev, unsigned change)
>        struct sk_buff *skb;
>        int err = -ENOBUFS;
> 
> -       skb = nlmsg_new(if_nlmsg_size(0), GFP_KERNEL);
> +       skb = nlmsg_new(if_nlmsg_size(0), GFP_ATOMIC);
>        if (skb == NULL)
>                goto errout;

This should only be called under RTNL so it should never be atomic.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html