netdev - Re: [TG3 1/8]: Save MSI state before suspend.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070213115825.0a6119ed@freekitty>
Date:	Tue, 13 Feb 2007 11:58:25 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	"Michael Chan" <mchan@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [TG3 1/8]: Save MSI state before suspend.

On Tue, 13 Feb 2007 12:13:32 -0800
"Michael Chan" <mchan@...adcom.com> wrote:

> [TG3]: Save MSI state before suspend.
> 
> This fixes the following problem:
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=7969
> 
> The MSI state needs to be saved during suspend.  PCI state saved
> during tg3_init_one() does not contain valid MSI state because
> MSI hasn't been enabled.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> 

I think you have to move the original pci_save_state call, otherwise
you will call pci_save_state twice and leak memory.  pci_save_state
allocates memory to store MSI and other information. Look at pci_save_pcie_state
etc.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html