lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Feb 2007 15:28:34 +0200 From: "Ahmed S. Darwish" <darwish.07@...il.com> To: Mark Brown <broonie@...ena.org.uk> Cc: Tim Hockin <thockin@...kin.org>, Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [patch 1/2] natsemi: Add support for using MII port with no PHY On Wed, Feb 14, 2007 at 10:02:04AM +0000, Mark Brown wrote: > Signed-Off-By: Mark Brown <broonie@...ena.org.uk> > [...] > - if (np->phy_addr_external == PHY_ADDR_NONE) { > + /* If we're ignoring the PHY it doesn't matter if we can't > + * find one. */ > + if (!np->ignore_phy && np->phy_addr_external == PHY_ADDR_NONE) { [...] > + if (!np->ignore_phy) { > + /* The link status field is latched: it remains low > + * after a temporary link failure until it's read. We > + * need the current link status, thus read twice. > + */ > + mdio_read(dev, MII_BMSR); > + bmsr = mdio_read(dev, MII_BMSR); [...] > /* > + * If we're ignoring the PHY then autoneg and the internal > + * transciever are really not going to work so don't let the > + * user select them. > + */ > + if (np->ignore_phy && (ecmd->autoneg == AUTONEG_ENABLE || A trivial comment actually, Is there a point to write multi-line comments in two different formats ? Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists