lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 14 Feb 2007 22:38:15 +0000
From:	"Hugo Santos" <hugosantos@...il.com>
To:	"Herbert Xu" <herbert@...dor.apana.org.au>
Cc:	hasso@...pak.ee, yoshfuji@...ux-ipv6.org, davem@...emloft.net,
	netdev@...r.kernel.org, aramoto@...ux-ipv6.org,
	kozakai@...ux-ipv6.org
Subject: Re: [GIT PULL] IPv6 Updates

  Thank you all for these changes.

  Hugo

On 2/14/07, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> Herbert Xu <herbert@...dor.apana.org.au> wrote:
> >
> > [IPV4] devinet: Register inetdev earlier.
>
> I needed to move the panic call as well.
>
> [IPV4] devinet: Register inetdev earlier.
>
> This patch allocates inetdev at registration for all devices
> in line with IPv6.  This allows sysctl configuration on the
> devices to occur before they're brought up or addresses are
> added.
>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
>
> Cheers,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> --
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index ba5e7f4..2224f8e 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
> @@ -1055,12 +1055,14 @@ static int inetdev_event(struct notifier_block *this, unsigned long event,
>         ASSERT_RTNL();
>
>         if (!in_dev) {
> -               if (event == NETDEV_REGISTER && dev == &loopback_dev) {
> +               if (event == NETDEV_REGISTER) {
>                         in_dev = inetdev_init(dev);
> -                       if (!in_dev)
> -                               panic("devinet: Failed to create loopback\n");
> -                       in_dev->cnf.no_xfrm = 1;
> -                       in_dev->cnf.no_policy = 1;
> +                       if (dev == &loopback_dev) {
> +                               if (!in_dev)
> +                                       panic("devinet: Failed to create loopback\n");
> +                               in_dev->cnf.no_xfrm = 1;
> +                               in_dev->cnf.no_policy = 1;
> +                       }
>                 }
>                 goto out;
>         }
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists