netdev - Re: [PATCH] dm9000: do not kfree() netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070216095647.GA24236@fluff.org.uk>
Date:	Fri, 16 Feb 2007 09:56:47 +0000
From:	Ben Dooks <ben@...ff.org.uk>
To:	netdev@...r.kernel.org
Cc:	rmk@....linux.org.uk
Subject: Re: [PATCH] dm9000: do not kfree() netdevice

On Mon, Feb 12, 2007 at 12:05:39PM +0000, Ben Dooks wrote:
> The DM9000 network driver is calling kfree() on an netdev
> causing the system to oops if the probe fails. The right
> thing to do is call free_netdev().
> 
> Thanks to Russell King for spotting this.
> 
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> 
> diff -urpN -X ../dontdiff linux-2.6.20/drivers/net/dm9000.c linux-2.6.20-dmfix/drivers/net/dm9000.c
> --- linux-2.6.20/drivers/net/dm9000.c	2007-02-04 18:44:54.000000000 +0000
> +++ linux-2.6.20-dmfix/drivers/net/dm9000.c	2007-02-12 12:01:22.000000000 +0000
> @@ -601,7 +601,7 @@ dm9000_probe(struct platform_device *pde
>  	printk("%s: not found (%d).\n", CARDNAME, ret);
>  
>  	dm9000_release_board(pdev, db);
> -	kfree(ndev);
> +	free_netdev(ndev);
>  
>  	return ret;
>  }
> @@ -1194,7 +1194,7 @@ dm9000_drv_remove(struct platform_device
>  
>  	unregister_netdev(ndev);
>  	dm9000_release_board(pdev, (board_info_t *) ndev->priv);
> -	kfree(ndev);		/* free device structure */
> +	free_netdev(ndev);		/* free device structure */
>  
>  	PRINTK1("clean_module() exit\n");

Do I need to send this patch to a particual person
to ensure that it gets included into the kernel?

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html