netdev - Re: [PATCH] macb: Remove inappropriate spinlocks around mii calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 17 Feb 2007 15:31:13 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Haavard Skinnemoen <hskinnemoen@...el.com>
CC:	netdev@...r.kernel.org, Andrew Victor <andrew@...people.com>,
	Patrice Vilchez <patrice.vilchez@....atmel.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [PATCH] macb: Remove inappropriate spinlocks around mii calls

Haavard Skinnemoen wrote:
> Remove spin_lock_irqsave() around mii_ethtool_gset, mii_ethtool_sset
> and generic_mii_ioctl. These are unnecessary and harmful because
> the mii calls may call back into the mdio functions, which may sleep.
> 
> Pointed out by David Brownell.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@...el.com>
> ---
>  drivers/net/macb.c |   24 +++---------------------
>  1 files changed, 3 insertions(+), 21 deletions(-)

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html