lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Feb 2007 12:47:57 -0800 From: Auke Kok <auke-jan.h.kok@...el.com> To: Jeff Garzik <jeff@...zik.org> CC: netdev@...r.kernel.org, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Kok, Auke" <auke@...-projects.org>, "Ronciak, John" <john.ronciak@...el.com> Subject: Re: [PATCH 1/3] e1000: fix shared interrupt warning message Jeff Garzik wrote: > Kok, Auke wrote: >> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com> >> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com> >> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> >> --- >> >> drivers/net/e1000/e1000_main.c | 12 ++++++------ >> 1 files changed, 6 insertions(+), 6 deletions(-) > > applied 1-3, though patch #1 had a noticable lack of description. you > should describe your change, not just the condition that prompted it. > operation reordering is something that people shouldn't have to /try/ to > understand. Things should just be obvious, and if not, document why. For the record then: It is suspected that workarounds in the _up() routine of e1000 can cause the receive unit to be enabled before we're all done initializing the adapter data. An interrupt arriving before we're all done setting up obviously causes problems. To fix, we postpone enabling interrupts completely until the software intialization is finished. Thanks, Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists