lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Feb 2007 23:12:52 +0100 From: Francois Romieu <romieu@...zoreil.com> To: Michal Piotrowski <michal.k.k.piotrowski@...il.com> Cc: LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org Subject: Re: 2.6.20-git14 rtl8139 possible circular locking dependency detected Michal Piotrowski <michal.k.k.piotrowski@...il.com> : [...] Did you enable RTL8139_DEBUG ? If so you can try the patch below. diff --git a/drivers/net/8139too.c b/drivers/net/8139too.c index 35ad5cf..da61368 100644 --- a/drivers/net/8139too.c +++ b/drivers/net/8139too.c @@ -634,7 +634,6 @@ static int rtl8139_close (struct net_dev static int netdev_ioctl (struct net_device *dev, struct ifreq *rq, int cmd); static struct net_device_stats *rtl8139_get_stats (struct net_device *dev); static void rtl8139_set_rx_mode (struct net_device *dev); -static void __set_rx_mode (struct net_device *dev); static void rtl8139_hw_start (struct net_device *dev); static void rtl8139_thread (struct work_struct *work); static void rtl8139_tx_timeout_task(struct work_struct *work); @@ -2497,10 +2496,11 @@ static struct net_device_stats *rtl8139_ return &tp->stats; } -/* Set or clear the multicast filter for this adaptor. - This routine is not state sensitive and need not be SMP locked. */ - -static void __set_rx_mode (struct net_device *dev) +/* + * Set or clear the multicast filter for this adaptor. + * This routine is not state sensitive and need not be SMP locked. + */ +static void rtl8139_set_rx_mode (struct net_device *dev) { struct rtl8139_private *tp = netdev_priv(dev); void __iomem *ioaddr = tp->mmio_addr; @@ -2545,16 +2545,6 @@ static void __set_rx_mode (struct net_de RTL_W32_F (MAR0 + 4, mc_filter[1]); } -static void rtl8139_set_rx_mode (struct net_device *dev) -{ - unsigned long flags; - struct rtl8139_private *tp = netdev_priv(dev); - - spin_lock_irqsave (&tp->lock, flags); - __set_rx_mode(dev); - spin_unlock_irqrestore (&tp->lock, flags); -} - #ifdef CONFIG_PM static int rtl8139_suspend (struct pci_dev *pdev, pm_message_t state) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists