lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Feb 2007 18:20:33 -0800 From: Auke Kok <auke-jan.h.kok@...el.com> To: Francois Romieu <romieu@...zoreil.com> CC: Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org, "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Kok, Auke" <auke@...-projects.org>, "Ronciak, John" <john.ronciak@...el.com> Subject: Re: [PATCH 1/3] e1000: fix shared interrupt warning message Francois Romieu wrote: > Auke Kok <auke-jan.h.kok@...el.com> : > [...] >> It is suspected that workarounds in the _up() routine of e1000 can cause > ^^^^^^^^^ >> the receive unit to be enabled before we're all done initializing the >> adapter data. An interrupt arriving before we're all done setting up >> obviously causes problems. To fix, we postpone enabling interrupts >> completely until the software intialization is finished. > > Call me dense but is there a chance that the same receive unit that should > not be enabled now emits interrupts between e1000_up() and request_irq() ? turning on the receive unit starts the rx logic on the mac, but doesn't make the mac generate interrupts as far as I know. The fix was verified and even suggested earlier by some people as well. Cheers, Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists