netdev - Re: [PATCH 2/2] RTNL and flush_scheduled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070219071828.GA1900@ff.dom.local>
Date:	Mon, 19 Feb 2007 08:18:28 +0100
From:	Jarek Poplawski <jarkao2@...pl>
To:	Ben Greear <greearb@...delatech.com>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org,
	Kyle Lucke <klucke@...ibm.com>,
	Raghavendra Koushik <raghavendra.koushik@...erion.com>,
	Al Viro <viro@....linux.org.uk>
Subject: Re: [PATCH 2/2] RTNL and flush_scheduled_work deadlocks

On Mon, Feb 19, 2007 at 07:55:48AM +0100, Jarek Poplawski wrote:
...
> So to use this we only need such changes:
> 
>  ... some_delayed_work_func(...)
>  {
> 	...
> -	rtnl_lock();
> +	rtnl_lock_work();
> 	...
> -	rtnl_unlock();
> +	rtnl_unlock_work();
>  }
> 
>  ... some_delayed_work_func(...)

Sorry! Of course:

  ... some_closing_with_flush_func(...)
>  {
> 	...
> +	rtnl_set_flush();
> 	flush_scheduled_work;
> 	/* or cancel_rearming_delayed_work(...); etc. */
> +	rtnl_unset_flush();
>  }

Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html