netdev - Re: [PATCH] chelsio: Fix non-NAPI compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45DBFD66.7070305@chelsio.com>
Date:	Wed, 21 Feb 2007 00:05:58 -0800
From:	Divy Le Ray <divy@...lsio.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] chelsio: Fix non-NAPI compile

Roland Dreier wrote:
> Chelsio without NAPI enabled has been broken (won't compile) since
> 3de00b89 ("chelsio: NAPI speed improvement"):
>
>     drivers/net/chelsio/sge.c: In function `t1_interrupt`:
>     drivers/net/chelsio/sge.c:1716: error: `Q` undeclared (first use in this function)
>
> The change below seems to add back in the declaration and
> initialization of `Q` that was removed by mistake, and at least makes
> the driver compile for me, although I have no hardware and hence no
> way to test whether this actually works.
>
> Signed-off-by: Roland Dreier <rolandd@...co.com>
>   
Roland,

You beat me :)

Cheers,
Divy

> ---
> Hi Stephen, since you seem to be looking after this driver a little
> bit (and since you broke it ;), I'll send this patch to you.
>
> If this seems right to you, please merge it (although perhaps it would
> make more sense just to kill the non-NAPI code, since no one noticed
> it didn't compile).
>
>
> diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c
> index 89a6827..326d4a6 100644
> --- a/drivers/net/chelsio/sge.c
> +++ b/drivers/net/chelsio/sge.c
> @@ -1696,6 +1696,7 @@ irqreturn_t t1_interrupt(int irq, void *cookie)
>  {
>  	int work_done;
>  	struct adapter *adapter = cookie;
> +	struct respQ *Q = &adapter->sge->respQ;
>  
>  	spin_lock(&adapter->async_lock);
>  
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html