netdev - Re: Extensible hashing and RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p73y7mrd6o9.fsf@bingen.suse.de>
Date:	21 Feb 2007 13:41:26 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Evgeniy Polyakov <johnpol@....mipt.ru>, akepner@....com,
	linux@...izon.com, davem@...emloft.net, netdev@...r.kernel.org,
	bcrl@...ck.org
Subject: Re: Extensible hashing and RCU

Eric Dumazet <dada1@...mosbay.com> writes:
> 
> For example, sock_wfree() uses 1.6612 % of cpu because of false sharing of 
> sk_flags (dirtied each time SOCK_QUEUE_SHRUNK is set :(

Might be easily fixable by moving the fields around a bit?

> If we want to optimize tcp, we should reorder fields to reduce number of cache 
> lines, not change algos. struct sock fields are currently placed to reduce 
> holes, while they should be grouped by related fields sharing cache lines.

Regrouping is definitely a good thing; but I'm not sure why you are so
deadset against exploring other data structures. The promise of RCUing
and avoiding the big hash tables seems alluding to me, even if it 
only breaks even in the end in terms of cycles.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html