netdev - Re: [PATCH] TCP : keep copied_seq, rcv_wup and rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200702221143.32622.dada1@cosmosbay.com>
Date:	Thu, 22 Feb 2007 11:43:32 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] TCP : keep copied_seq, rcv_wup and rcv_next together

On Thursday 22 February 2007 11:32, David Miller wrote:
> From: Eric Dumazet <dada1@...mosbay.com>
> Date: Thu, 22 Feb 2007 11:22:02 +0100
>
> > rcv_wup and copied_seq should be next to rcv_nxt field, to lower number
> > of active cache lines in hot paths. (tcp_rcv_established(), tcp_poll(),
> > ...)
>
> Please fixup the assignment order in tcp_create_openreq_child() else
> we'll get a new store buffer stall during socket creation :-)

OK :)

I wonder if :

newtp->snd_nxt = newtp->snd_una = newtp->snd_sml = treq->snt_isn + 1;

is correct, since compiler will write snd_sml, then snd_una, and snd_nxt

Maybe we should also reorder this too ?

Eric
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html