netdev - Re: [PATCH 1/2][TCP] YeAH-TCP: algorithm implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070222113636.28ba1896@freekitty>
Date:	Thu, 22 Feb 2007 11:36:36 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	"Angelo P. Castellani" <angelo.castellani@...il.com>
Cc:	"David Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	francesco@....infocom.uniroma1.it, andrea.baiocchi@...roma1.it
Subject: Re: [PATCH 1/2][TCP] YeAH-TCP: algorithm implementation

Minor comments:

1. Please move  div64_64 out of yeah-tcp (and cubic where you copied it).
   to asm-generic/div64.h

2. Don't need separate tcp_yeah.h just put it in tcp_yeah.c. Also, maybe
   the vegas stuff you copied should go in one place? tcp/vegas.h?

3. whitespace:
	don't do:
		x+=someexpression
		... = max( x, ...
	instead:
		x += someexpression
		... = max(x, ...
	Using indent script in scripts/Lindent will fix these.

4. See if you can replace uses of min_t and max_t with min and max by having
   proper matching types on args. Basically if you need to cast maybe original
   type was wrong.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html