netdev - Re: [Kgdb-bugreport] [PATCH 2.6.20-rc7] 8139too KGDBoE fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45DF3DAB.3010902@ru.mvista.com>
Date:	Fri, 23 Feb 2007 22:16:59 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Mark Huth <mhuth@...sta.com>,
	"Amit S. Kale" <amitkale@...syssoft.com>, netdev@...r.kernel.org,
	Mithlesh Thukral <mithlesh@...syssoft.com>,
	Vitaly Wool <vwool@...mvista.com>
Subject: Re: [Kgdb-bugreport] [PATCH 2.6.20-rc7] 8139too KGDBoE fix

Hello.

Stephen Hemminger wrote:

>>>>>This thread came up on kgdb-bugreport mailing list. Could you please suggest 
>>>>>us what's the correct way of fixing this problem?

>>>>>1. When running a kgdb on RTL8139 ethernet interface: 8139too driver prints 
>>>>>too many "Out-of-sync dirty pointer" messages on console and gdb can't 
>>>>>connect to kgdb stub. These messages can be suppressed, though it still 
>>>>>results in connection failures frequently. 

>>>>We think this comes from calling the driver while the queue is stopped.  
>>>>Drivers should not do horrible things when hard start is called with the 
>>>>queue stopped, but unfortunately, at this time, at least some drivers 
>>>>do  explode or complain under that condition.

>>>The kernel is built on a set of assumptions about calling context. Your
>>>out of tree code is violating one of them. Why not check for stopped queue
>>>and do some action to try and clear it, that is what netconsole does.

>>    The queue can't be stopped when the netpoll traffic trapping is enabled 
>>(cause this effectively bypasses queue control), So, the stopped queue 
>>indoication doesn't work also -- *that* is the problem. It's not at all 
>>specific to KGBoE -- only to traffic trapping.

> You can't ask a device to send a packet when it has no resources.

    When traffic trapping is enabled, and driver stops the queue, the 
__LINK_STATE_XOFF flag does *not* get set, so netif_queue_stopped() resturns 
*zero*.  What may be done in this situation?

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html