| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20070222.224236.95058339.davem@davemloft.net> Date: Thu, 22 Feb 2007 22:42:36 -0800 (PST) From: David Miller <davem@...emloft.net> To: jheffner@....edu Cc: netdev@...r.kernel.org Subject: Re: [PATCH] fix limited slow start bug John, what tree did you diff this against? I can tell you didn't create this patch against anything actually in any of my trees, because: diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c index 7fd2910..a0c894f 100644 --- a/net/ipv4/tcp_cong.c +++ b/net/ipv4/tcp_cong.c @@ -303,9 +303,9 @@ void tcp_slow_start(struct tcp_sock *tp) tp->snd_cwnd_cnt += cnt; See that line right before the snd_cwnd_cnt increment? There is a tab there in your patch on that empty line. Yoshifuji eliminated all extraneous trailing whitespaces, and spaces that should be tabs, across the entire networking, several weeks ago. Including the tab on that empty line in your patch. This means that you applied the YeaH and your own patch to another source tree, perhaps 2.6.20 or similar, and then generated your fix against that. Please don't do things like that. Instead please produce patches against the tree they will end up being applied to so that they will apply cleanly for me. I can't believe how much time I spend getting people to produce correct patches :-/ Anyways, I applied this by hand, but next time I definitely am not going to. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists