netdev - Re: Slow connection with RTL8168b/8111b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070224114147.GA2282@electric-eye.fr.zoreil.com>
Date:	Sat, 24 Feb 2007 12:41:47 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Dirk <biecie547@...il.com>
Cc:	netdev@...r.kernel.org, Edward Hsu <edward_hsu@...ltek.com>
Subject: Re: Slow connection with RTL8168b/8111b

Dirk <biecie547@...il.com> :
[...]
> I tried running 2.6.21-rc1 with the patch you mentioned, but it still
> has thesame speed problem. Building the driver with or without NAPI
> support makes no difference.

Thanks for testing.

Can you try the patch below on top of:

http://www.fr.zoreil.com/people/francois/misc/20070223-2.6.21-rc1-r8169-test.patch

Don't hurry: it's saturday. :o)

This patch fixes two problems:

  - Call unregister_netdev() before pci_disable_msi() to fix
    BUG_ON(irq_has_action(dev->first_msi_irq)) in drivers/pci/msi.c:658

  - Call RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb) in rtl_hw_start_8168()
    I don't know why, I have no specification of this device, I
    simply used the try & error method.

Signed-off-by: Bernhard Walle <bwalle@...e.de>

---
 drivers/net/r8169.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.21-rc1/drivers/net/r8169.c
===================================================================
--- linux-2.6.21-rc1.orig/drivers/net/r8169.c
+++ linux-2.6.21-rc1/drivers/net/r8169.c
@@ -1795,10 +1795,10 @@ static void __devexit rtl8169_remove_one
 
 	flush_scheduled_work();
 
+	unregister_netdev(dev);
 	if (tp->msi)
 		pci_disable_msi(pdev);
 	tp->msi = 0;
-	unregister_netdev(dev);
 	rtl8169_release_board(pdev, dev, tp->mmio_addr);
 	pci_set_drvdata(pdev, NULL);
 }
@@ -2060,6 +2060,7 @@ static void rtl_hw_start_8168(struct net
 		tp->intr_event &= ~RxOverflow;
 	}
 
+	RTL_W8(ChipCmd, CmdTxEnb | CmdRxEnb);
 	rtl_set_rx_tx_desc_registers(tp, ioaddr);
 
 	RTL_W8(Cfg9346, Cfg9346_Lock);
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html