netdev - Re: [PATCH] Fix oops in xfrm4_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070226.121049.90121540.davem@davemloft.net>
Date:	Mon, 26 Feb 2007 12:10:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	bwalle@...e.de, miika@....fi, netdev@...r.kernel.org
Subject: Re: [PATCH] Fix oops in xfrm4_dst_destroy()

From: Patrick McHardy <kaber@...sh.net>
Date: Mon, 26 Feb 2007 01:24:37 +0100

> Bernhard Walle wrote:
> > With 2.6.21-rc1, I get an oops when running 'ifdown eth0' and an IPsec
> > connection is active. If I shut down the connection before running 'ifdown
> > eth0', then there's no problem.  The critical operation of this script is to
> > kill dhcpd.
> > 
> > The problem is probably caused by commit with git identifier
> > 4337226228e1cfc1d70ee975789c6bd070fb597c (Linus tree) "[IPSEC]: IPv4 over IPv6
> > IPsec tunnel".
> > 
> > This patch fixes that oops. I don't know the network code of the Linux kernel
> > in deep, so if that fix is wrong, please change it. But please fix the oops. :)
> 
> Looks good, when the xfrm_dst is freed in __xfrm4_bundle_create
> after a failed call to xfrm_dst_lookup the xfrm pointer is not
> set, and this is also expected by xfrm_dst_destroy.
> 
> Acked-by: Patrick McHardy <kaber@...sh.net>

Patch applied, thanks everyone.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html